Return 410 for stale id in set rtif API#68902
Open
FrankYang0529 wants to merge 1 commit into
Open
Conversation
1 task
FrankYang0529
changed the title
FrankYang0529
force-pushed
the
airflow-66416
branch
from
417db0a to
77810b5
Compare
When a task whose operator sets overwrite_rtif_after_execution=True leaves RUNNING via a retry or a clear, the server regenerates the task instance id and archives the old one. finalize() still overwrites RTIF with the stale id, so the API server returns 404 and the worker logs a spurious error traceback on top of the task's real outcome. The RTIF will be wrote in next id. Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-66416
branch
from
77810b5 to
c81b4a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A task whose operator sets
overwrite_rtif_after_execution=Truelogs a 404 error when setting rtif. The server regenerates the task instance id (archiving the old one to history) via a retry or a clear. However, the worker'sfinalize()still overwritesRTIF using the stale id.
How
When a TI id is missing from the live table but present in history,
PUT /task-instances/{id}/rtifnow returns410 Goneinstead of404. The hearbeat API also uses this mechanism. The supervisor treats that410as an expected, skippable outcome (debug log, no error). A genuine404still propagates as a real error.closes: #66416
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.