Skip to content

Fix timezone-dependent symlink test in TestFileProcessorHandler#68910

Open
shreyamalviya wants to merge 1 commit into
apache:mainfrom
shreyamalviya:fix-timezone-issue-in-UT
Open

Fix timezone-dependent symlink test in TestFileProcessorHandler#68910
shreyamalviya wants to merge 1 commit into
apache:mainfrom
shreyamalviya:fix-timezone-issue-in-UT

Conversation

@shreyamalviya

Copy link
Copy Markdown

On running the unit tests, test_symlink_latest_log_directory was failing for me because of a timezone issue (I'm in BST/UTC+1).

The tests compute the expected log-directory name from timezone.utcnow() but then travel to that date with a naive date string: time_machine.travel("2026-06-24", ...). time_machine interprets a naive datetime as local time, so under a positive UTC offset, the travel target lands on the previous day in UTC (2026-06-24 00:00 BST == 2026-06-23 23:00 UTC). The handler then builds its directory from utcnow() (2026-06-23) while the assertion expects 2026-06-24, producing:

AssertionError: assert '2026-06-23' == '2026-06-24'

This is a latent test bug that surfaces for any contributor in a positive-offset timezone.

The fix makes the time_machine.travel targets explicit UTC instants (f"{date} 00:00:00+00:00") so the day no longer shifts with the host timezone. Behaviour under test is unchanged; only the test's time control is made timezone-independent.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: GitHub Copilot (Claude Opus 4.8) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg

boring-cyborg Bot commented Jun 23, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant