cli: Fix TypeError in 'airflow db shell' when database name is missing#68913
Open
sejal-gupta-ksolves wants to merge 1 commit into
Open
cli: Fix TypeError in 'airflow db shell' when database name is missing#68913sejal-gupta-ksolves wants to merge 1 commit into
sejal-gupta-ksolves wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #68897
Problem
When configuring the
AIRFLOW__DATABASE__SQL_ALCHEMY_CONNenvironment variable without explicitly appending a database name component to the URI path (e.g.,postgresql://postgres:postgres@postgres:5432), the commandairflow db checkpasses gracefully. However, runningairflow db shellcrashes with an unhandled, crypticTypeError: expected str, bytes or os.PathLike object, not NoneType.Solution
Updated the
shellcommand function insideairflow/cli/commands/db_command.pyto add a global validation guardrail check right after retrieving the database URL structure. Ifurl.databaseevaluates toNoneor is empty, the command now proactively raises a clean, standard Python built-inValueErrordetailing that the configuration is invalid.