Standardize ECS TaskDoneTrigger on region_name and AWS hook parameters#68923
Draft
o-nikolas wants to merge 3 commits into
Draft
Standardize ECS TaskDoneTrigger on region_name and AWS hook parameters#68923o-nikolas wants to merge 3 commits into
o-nikolas wants to merge 3 commits into
Conversation
TaskDoneTrigger used a non-standard 'region' argument and ignored SSL verification and botocore configuration. It now uses region_name and accepts verify and botocore_config like the other Amazon provider triggers, and EcsRunTaskOperator forwards those values when deferring, completing the trigger portion of the ECS migration in apache#35278.
boring-cyborg
Bot
added
area:providers
provider:amazon
Preserve backward compatibility for ECS TaskDoneTrigger after standardizing on region_name: the old region argument is still accepted as a deprecated alias, emitting AirflowProviderDeprecationWarning. This keeps existing keyword callers working and lets deferred-task triggers serialized by older versions deserialize after upgrade.
The deprecated region alias is folded into region_name at construction time, so it intentionally does not round-trip through serialize() -- the same by-design pattern already used for GKEJobTrigger's pod_name alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskDoneTriggerused a non-standardregionargument and ignored SSLverification and botocore configuration. It now uses
region_nameand acceptsverifyandbotocore_configlike the other Amazon provider triggers, buildingboth the ECS and CloudWatch-logs hooks with them, and
EcsRunTaskOperatorforwards those values when deferring.
This completes the trigger portion of the ECS item in the base-AWS-classes
migration initiative.
related: #35278
Was generative AI tooling used to co-author this PR?
Generated-by: Kiro (claude-opus-4.8) following the guidelines