Fix DatabricksWorkflowTaskGroup ignoring deps set before with block#68924
Open
moomindani wants to merge 1 commit into
Open
Fix DatabricksWorkflowTaskGroup ignoring deps set before with block#68924moomindani wants to merge 1 commit into
moomindani wants to merge 1 commit into
Conversation
…re with block When ``>>`` was called before the ``with task_group:`` block, the dependency was recorded on the task group but never transferred to the launch task (upstream) or the leaf tasks (downstream), because those tasks did not exist yet. Transfer ``self.upstream_task_ids`` and ``self.downstream_task_ids`` in ``__exit__()`` after creating the internal tasks. closes: apache#51598 Co-authored-by: shubhgurav0590 <shubhgurav0590@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
DatabricksWorkflowTaskGroupso that upstream/downstream dependencies set via>>before thewithblock are correctly transferred to the internallaunchtask and leaf tasks.When
>>was called before thewith task_group:block, the dependency was recorded on the task group but never transferred to thelaunchtask (upstream) or the leaf tasks (downstream), because those tasks did not exist yet. Transferself.upstream_task_idsandself.downstream_task_idsin__exit__()after creating the internal tasks.Note: PR #67369 by @shubhgurav0590 identified the correct approach in this comment but the fix was never committed before the PR went stale. This PR implements that approach and adds downstream coverage. The commit includes Co-authored-by to preserve credit.
closes: #51598
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines