Propagate AWS hook parameters through RedshiftClusterTrigger#68925
Open
o-nikolas wants to merge 1 commit into
Open
Propagate AWS hook parameters through RedshiftClusterTrigger#68925o-nikolas wants to merge 1 commit into
o-nikolas wants to merge 1 commit into
Conversation
RedshiftClusterTrigger now accepts and serializes region_name, verify, and botocore_config and builds its hook with them, and RedshiftClusterSensor forwards those values when deferring. Previously a deferred RedshiftClusterSensor silently dropped the region, SSL verification, and botocore configuration, completing the trigger portion of the Redshift cluster migration in apache#35278.
boring-cyborg
Bot
added
area:providers
provider:amazon
eladkal
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedshiftClusterTriggernow accepts and serializesregion_name,verify, andbotocore_configand builds its hook with them, andRedshiftClusterSensorforwards those values when deferring. Previously a deferred
RedshiftClusterSensorsilently dropped the region, SSL verification, and botocore configuration.
The trigger keeps inheriting
BaseTrigger(rather thanAwsBaseWaiterTrigger)because it polls for an arbitrary
target_status, which no single boto waitercovers — the same approach used by
GlueCatalogPartitionTrigger.This completes the trigger portion of the Redshift cluster item in the
base-AWS-classes migration initiative.
related: #35278
Was generative AI tooling used to co-author this PR?
Generated-by: Kiro (claude-opus-4.8) following the guidelines