Make Amazon SageMaker triggers inherit AWS base classes#68927
Draft
o-nikolas wants to merge 2 commits into
Draft
Make Amazon SageMaker triggers inherit AWS base classes#68927o-nikolas wants to merge 2 commits into
o-nikolas wants to merge 2 commits into
Conversation
SageMakerTrigger and SageMakerPipelineTrigger now inherit AwsBaseWaiterTrigger, so they accept and propagate the generic AWS hook parameters (region_name, verify, botocore_config) consistently with the rest of the Amazon provider, completing the trigger portion of the SageMaker migration in apache#35278.
boring-cyborg
Bot
added
area:providers
provider:amazon
Preserve backward compatibility for SageMakerTrigger after switching to the AwsBaseWaiterTrigger naming: poke_interval and max_attempts are still accepted as deprecated aliases for waiter_delay and waiter_max_attempts, emitting AirflowProviderDeprecationWarning. This keeps existing keyword callers working and lets deferred-task triggers serialized by older versions deserialize after upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SageMakerTriggerandSageMakerPipelineTriggernow inheritAwsBaseWaiterTrigger,so they accept and propagate the generic AWS hook parameters (
region_name,verify,botocore_config) consistently with the rest of the Amazon provider.SageMakerPipelineTriggerkeeps its per-step pipeline-progress logging via anoverridden
run(), the same pattern used byGlueJobCompleteTrigger.The SageMaker operators that defer to these triggers were updated accordingly
(
waiter_delay/waiter_max_attemptsparameters and the successTriggerEventpayload).
This completes the trigger portion of the SageMaker item in the base-AWS-classes
migration initiative.
related: #35278
Was generative AI tooling used to co-author this PR?
Generated-by: Kiro (claude-opus-4.8) following the guidelines