fix(keycloak): add missing Dag resource to Op-team permission - #71320
Open
waterWang wants to merge 1 commit into
Open
fix(keycloak): add missing Dag resource to Op-team permission#71320waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
The Op-{team} permission created by the create-team command was missing
the Dag:{team} resource. This caused users with the Op role to not
receive the expected permission for the team's DAG resource.
The fix adds Dag:{team} to the Op-{team} permission resources in two
places:
1. _get_permissions_to_create() — the initial permission creation
2. _attach_team_permissions() — the policy attachment for create-team
Fixes apache#71319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(keycloak): add missing Dag resource to Op-team permission
The Op-{team} permission created by the create-team command was missing
the Dag:{team} resource. This caused users with the Op role to not
receive the expected permission for the team's DAG resource.
The fix adds Dag:{team} to the Op-{team} permission resources in two
places:
Fixes #71319