Restore DagBag include_examples as a deprecated no-op argument - #71323
Open
patil-rushikesh wants to merge 2 commits into
Open
Restore DagBag include_examples as a deprecated no-op argument#71323patil-rushikesh wants to merge 2 commits into
patil-rushikesh wants to merge 2 commits into
Conversation
Airflow 3.3.0 removed the argument outright with no deprecation cycle, so Dag-validation scripts calling DagBag(include_examples=False) began failing with TypeError on a minor-version upgrade, and the removal was not mentioned in the release notes. Accept the argument again, warn with RemovedInAirflow4Warning, and ignore it so existing callers keep working until Airflow 4; document the behaviour change in the newsfragment that covers the example-Dags-via-bundles switch.
patil-rushikesh
requested review from
ephraimbuddy and
jedcunningham
as code owners
August 8, 2026 07:30
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Airflow 3.3.0 removed the
include_examplesargument fromDagBagoutright (#66161): the deprecation warning and the removal landed in the same PR, so users got no deprecation cycle across releases, and the removal was not mentioned in the release notes. This broke the common Dag-validation patternDagBag(dag_folder=..., include_examples=False)with aTypeErroron a minor-version upgrade.This restores
include_examplesonDagBag.__init__andDagBag.collect_dagsas an accepted, deprecated argument: passing it emitsRemovedInAirflow4Warningand is otherwise ignored, since example Dags are now provided exclusively through the per-provider bundles gated by[core] load_examples. (Honoringinclude_examples=Trueagain would reintroduce the duplicate bundle registration that #66161 fixed; the no-op exactly matches old semantics for the dominantFalseusage.) The still-unreleased66161.significant.rstnewsfragment now documents the deprecation.A backport to
v3-3-testwould unbreak 3.3.x users in 3.3.2.closes: #70283
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines