Skip to content

Flush scheduled DagRun creation state promptly - #71331

Open
fat-catTW wants to merge 1 commit into
apache:mainfrom
fat-catTW:measure-dagrun-session-flush
Open

Flush scheduled DagRun creation state promptly#71331
fat-catTW wants to merge 1 commit into
apache:mainfrom
fat-catTW:measure-dagrun-session-flush

Conversation

@fat-catTW

Copy link
Copy Markdown
Contributor

Why

SchedulerJobRunner._create_dag_runs() had a TODO asking whether the scheduler should call session.flush() or session.expunge_all() while creating scheduled DagRuns.

The concern behind the TODO is that the scheduler may iterate over multiple Dags, create scheduled DagRuns, update DagModel scheduling fields, and create task instance rows in the same SQLAlchemy session. For larger Dags or larger batches of Dags, leaving ORM state pending until the outer transaction boundary can make it harder to reason about session growth and memory behavior.

This PR resolves that TODO by flushing after each successful scheduled DagRun creation and related DagModel scheduling-state update.

Why flush() Instead of expunge_all()

The narrower operation is enough for the state observed in this path.

session.flush() writes pending ORM changes to the database transaction while keeping objects attached to the session. That directly addresses the observed pending/dirty scheduler state after creating a scheduled DagRun and updating the corresponding DagModel.

session.expunge_all() does something broader: it detaches every ORM object from the session. That can reduce identity-map retention, but it also carries more behavioral risk because later scheduler code may still expect ORM objects to be attached, refreshable, or tracked by the session.

To decide whether expunge_all() was needed, this path was checked for retained ORM objects after DagRun creation. If creating larger Dags left one tracked DagRun or TaskInstance object per created row, flush() would not address that memory growth because it does not clear the session identity map.

A local pressure check with 20 Dags and 500 tasks per Dag created 10,000 TaskInstance rows. After _create_dag_runs() returned, the observed session state was:

session.new: 0
session.dirty: 0
identity_map: Counter({'DagModel': 20, 'DagVersion': 1, 'SerializedDagModel': 1, 'DagCode': 1})
螢幕擷取畫面 2026-08-08 204423
Was generative AI tooling used to co-author this PR?
  • [X] Yes (please specify the tool below)

Generated-by: [Codex] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@fat-catTW
fat-catTW requested review from XD-DENG and ashb as code owners August 8, 2026 12:53
@boring-cyborg boring-cyborg Bot added the area:Scheduler including HA (high availability) scheduler label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant