Move template-field validation out of GoogleCampaignManagerDeleteRepo… - #71343
Open
bujjibabukatta wants to merge 1 commit into
Open
Move template-field validation out of GoogleCampaignManagerDeleteRepo…#71343bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
…rtOperator.__init__
bujjibabukatta
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
shahar1
as code owners
August 9, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #70296.
Summary
Moves
report_name/report_idvalidation inGoogleCampaignManagerDeleteReportOperatorfrom
__init__intoexecute(), and removes the class from thevalidate-operators-initexemption list.Root cause
report_nameandreport_idare template fields, which are rendered after theconstructor runs. Validating them in
__init__therefore checks the un-renderedJinja expressions instead of the actual values — the reason this class was on the
exemption list.
Fix
campaign_manager.py— moved the "providereport_nameorreport_id" and"only one of them" checks from
__init__to the start ofexecute();__init__now only does plain
self.field = fieldassignments.validate_operators_init_exemptions.txt— removed theGoogleCampaignManagerDeleteReportOperatorentry (required in the same PR; thehook fails on a stale exemption once the class is compliant).
test_campaign_manager.py— added tests asserting both invalid cases (bothprovided / neither provided) now raise from
execute().Was generative AI tooling used ?
Generated-by: Claude following the guidelines