feat(ingress-controller): add imagePullSecrets support with global fallback#916
Open
ArnaudCHT wants to merge 2 commits intoapache:masterfrom
Open
feat(ingress-controller): add imagePullSecrets support with global fallback#916ArnaudCHT wants to merge 2 commits intoapache:masterfrom
ArnaudCHT wants to merge 2 commits intoapache:masterfrom
Conversation
…PullSecret Signed-off-by: Arnaud CHATELAIN <a.chatelain@actongroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add deployment.imagePullSecrets support in ingress-controller with fallback to global.imagePullSecrets.
Why
The ingress-controller deployment had no way to configure imagePullSecrets, forcing users to manually patch deployments or fork the chart.
Changes
#883
Testing
To test this PR, you can use the following commands: