fix(parquet): bss encoding and tests on big endian systems#663
Open
daniel-adam-tfs wants to merge 2 commits intoapache:mainfrom
Open
fix(parquet): bss encoding and tests on big endian systems#663daniel-adam-tfs wants to merge 2 commits intoapache:mainfrom
daniel-adam-tfs wants to merge 2 commits intoapache:mainfrom
Conversation
- Add platform-specific decodeByteStreamSplitBatchWidth{4,8}InByteOrder
for little-endian and s390x big-endian architectures.
- Update ByteStreamSplitDecoder to use new endianness-aware decoding
functions for correct behavior on all platforms.
…systems Fix TestPageIndexRoundTripSuite and TestEncoding tests on big-endian systems
daniel-adam-tfs
changed the title
zeroshade
reviewed
Feb 14, 2026
Comment on lines
+676
to
+682
| if endian.IsBigEndian { | ||
| buf := bytes.NewBuffer(nil) | ||
| if err := binary.Write(buf, binary.LittleEndian, val); err != nil { | ||
| panic(err) | ||
| } | ||
| return buf.Bytes() | ||
| } |
Member
There was a problem hiding this comment.
there is a ToLE function in internal/utils/ that might be better for this. For example:
val = utils.ToLE(val)
return unsafe.Slice((*byte)(unsafe.Pointer(&val)), unsafe.Sizeof(val))This would work because on LittleEndian systems, ToLE(val) is just defined as return val.
zeroshade
reviewed
Feb 14, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
just one nitpick, otherwise this looks good!
zeroshade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
To ensure the Arrow and Parquet Go libraries work correctly on big-endian architectures.
What changes are included in this PR?
Added endianness-aware BYTE_STREAM_SPLIT decoding in the parquet/encoding package.
Fixed tests in the parquet package to handle byte order correctly on big-endian systems.
Are these changes tested?
Yes, all affected unit tests now pass on both little-endian and big-endian machines. The changes specifically address some of the previously failing tests on big-endian systems.
Are there any user-facing changes?
No user-facing API changes. The changes are internal and ensure correct behavior on supported architectures.