Open
Conversation
jhorstmann
reviewed
Feb 5, 2026
jhorstmann
reviewed
Feb 5, 2026
jhorstmann
reviewed
Feb 5, 2026
jhorstmann
reviewed
Feb 5, 2026
jhorstmann
reviewed
Feb 5, 2026
alamb
reviewed
Feb 11, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
thanks @rambleraptor -- I think @jhorstmann 's comments are good to respond to, but otherwise this PR looks good to me
| self.decoders[encoding as usize] | ||
| .as_mut() | ||
| .expect("Decoder for dict should have been set") | ||
| match self.decoders[encoding as usize].as_mut() { |
Contributor
There was a problem hiding this comment.
did you find some code path that can trigger this error?
Contributor
|
It seems like there are some real CI errors that need to be addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We've been doing some internal work with Parquet and found a bunch of places where error messages could be improved or panics could be avoided.
I can split this up into multiple PRs if need be. I know it's an assortment of things.
What changes are included in this PR?
Are these changes tested?
Tests should continue to pass.
Are there any user-facing changes?