Open
Conversation
…1.1 (#49682) ### Rationale for this change Fixes #49586 `std::multimap::extract(key)` does not guarantee returning the first element when there are duplicate keys. ### What changes are included in this PR? Replace extract(key) with lower_bound(key) plus erase(iterator). `lower_bound` guarantees first matching element, then read `it->second` and then `erase` the node (`extract` is not needed as the node isn't reused here). ### Are these changes tested? Yes, CI jobs are passing. ### Are there any user-facing changes? No. * GitHub Issue: #49586 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Member
Author
|
@github-actions crossbow submit -g verify-rc-source |
github-actions
bot
added
Component: C++
awaiting committer review
Member
Author
|
@github-actions crossbow submit --group packaging |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ig for hcsshim on Windows (#49678) ### Rationale for this change The docker base docker image which installs all the vcpkg dependencies to build Windows wheels was failing to commit the layer for gRPC due to size. ### What changes are included in this PR? Two separate fixes that independently fix the issue: - Patch vcpkg for Windows to remove unconditional `/Z7` - Use D:/ drive instead of C:/ as it has bigger size for Docker storage ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * GitHub Issue: #49676 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Member
Author
|
@github-actions crossbow submit --group packaging |
Member
Author
|
@github-actions crossbow submit -g verify-rc-source |
github-actions
bot
removed
the
CI: Extra: Package: Linux
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…er outcome (#49698) ### Rationale for this change When we read an IPC message from an IPC file, we validate its associated body size against the amount required by the streaming decoder. However, we're currently only checking that the body size is large enough, not that it's exactly as expected. An invalid IPC file might advertise in its footer a `metaDataLength` that's larger than the actual serialized Flatbuffers payload. In that case, the associated body would start before the offset computed from the IPC file footer. ### What changes are included in this PR? 1. Strengthen body size check against expected decoder read, to ensure that the metadata length advertised in the IPC file footer is consistent with the actual size of the Flatbuffers-serialized metadata. 2. Refactor RecordBatch IPC loading to reduce code duplication. 3. (as a consequence of item 2 above) Fix latent bug where the IPC file reader did not apply the `ensure_alignment` option to buffers read from IPC. ### Are these changes tested? By additional fuzz regression file. ### Are there any user-facing changes? No. * GitHub Issue: #49697 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
github-actions
bot
removed
the
CI: Extra: Package: Linux
Member
Author
|
@github-actions crossbow submit --group packaging |
Member
Author
|
@github-actions crossbow submit -g verify-rc-source |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…idate serialized metadata (#49718) ### Rationale for this change FixedShapeTensorType::Deserialize should validate input from unknown sources. ### What changes are included in this PR? Adds stricter deserialization valideation. ### Are these changes tested? Yes. New tests are added. ### Are there any user-facing changes? Stricter validation should not be noticed if metadata is correct as per spec of fixed_shape_tensor. * GitHub Issue: #49716 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Member
Author
|
@github-actions crossbow submit --group packaging |
Member
Author
|
@github-actions crossbow submit -g verify-rc-source |
|
Revision: 2d6b12c Submitted crossbow builds: ursacomputing/crossbow @ actions-6b8a5ff655
|
|
Revision: 2d6b12c Submitted crossbow builds: ursacomputing/crossbow @ actions-f5721d5625
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to test the status of the 24.0.0 release branch on CI and should not be merged.