Skip to content

GH-49728: [CI] Set persist-credentials: false in checkout actions#49734

Open
thisisnic wants to merge 2 commits intoapache:mainfrom
thisisnic:GH-49728-persist-credentials
Open

GH-49728: [CI] Set persist-credentials: false in checkout actions#49734
thisisnic wants to merge 2 commits intoapache:mainfrom
thisisnic:GH-49728-persist-credentials

Conversation

@thisisnic
Copy link
Copy Markdown
Member

@thisisnic thisisnic commented Apr 14, 2026

Rationale for this change

Some CI jobs didn't have persist-credential set to false, which presents potential risks

What changes are included in this PR?

Set persist-credentials to false

Are these changes tested?

Run CI jobs

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #49728 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI awaiting committer review Awaiting committer review labels Apr 14, 2026
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should add it here:

with:
fetch-depth: {{ fetch_depth }}

and potentially here too:
with:
path: crossbow

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 14, 2026
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 14, 2026
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants