Skip to content

GH-49727: [CI] Pin GitHub Actions to commit SHAs instead of tags#49735

Open
thisisnic wants to merge 1 commit intoapache:mainfrom
thisisnic:GH-49727_pin_gha_shas
Open

GH-49727: [CI] Pin GitHub Actions to commit SHAs instead of tags#49735
thisisnic wants to merge 1 commit intoapache:mainfrom
thisisnic:GH-49727_pin_gha_shas

Conversation

@thisisnic
Copy link
Copy Markdown
Member

@thisisnic thisisnic commented Apr 14, 2026

Rationale for this change

GHA pinned to tags (movable) not SHAs (unique)

What changes are included in this PR?

Ping to SHAs

Are these changes tested?

CI will run

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #49727 has been automatically assigned in GitHub to PR creator.

@thisisnic
Copy link
Copy Markdown
Member Author

thisisnic commented Apr 14, 2026

I believe that these failures are expected:

Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did stop pinning hash specifically for those due to the policy not requiring pinning sha for non external actions, see:
#48327

@kou what are your thoughts on this?

@kevinjqliu do you have any insight on whether this should specify hash or not? I see that iceberg-python move to specify a hash (apache/iceberg-python#3194)
but based on policy: https://infra.apache.org/github-actions-policy.html the actions/checkout is not strictly required.

I don't want to merge this and remove it in 6 months, I'd rather push for a change of policy and require pinning for all.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants