GH-49727: [CI] Pin GitHub Actions to commit SHAs instead of tags#49735
Open
thisisnic wants to merge 1 commit intoapache:mainfrom
Open
GH-49727: [CI] Pin GitHub Actions to commit SHAs instead of tags#49735thisisnic wants to merge 1 commit intoapache:mainfrom
thisisnic wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
Member
Author
|
I believe that these failures are expected:
|
raulcd
reviewed
Apr 14, 2026
Member
raulcd
left a comment
There was a problem hiding this comment.
We did stop pinning hash specifically for those due to the policy not requiring pinning sha for non external actions, see:
#48327
@kou what are your thoughts on this?
@kevinjqliu do you have any insight on whether this should specify hash or not? I see that iceberg-python move to specify a hash (apache/iceberg-python#3194)
but based on policy: https://infra.apache.org/github-actions-policy.html the actions/checkout is not strictly required.
I don't want to merge this and remove it in 6 months, I'd rather push for a change of policy and require pinning for all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GHA pinned to tags (movable) not SHAs (unique)
What changes are included in this PR?
Ping to SHAs
Are these changes tested?
CI will run
Are there any user-facing changes?
No