-
Notifications
You must be signed in to change notification settings - Fork 903
ATLAS-5312: Add delete propagation support via propagateDelete flag o… #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhor-sanket
wants to merge
7
commits into
apache:master
Choose a base branch
from
bhor-sanket:ATLAS-5312
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,419
−253
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7f49272
ATLAS-5312: Add delete propagation support via propagateDelete flag o…
0cf3e84
ATLAS-5312: changes to add patch for delete_propagation
3f59b12
Merge branch 'apache:master' into ATLAS-5312
bhor-sanket 1d142a1
ATLAS-5312: Type System documentation covering the rename and delete …
bf0f9a5
ATLAS-5312: changes to fix Checkstyle violation.
397dd68
ATLAS-5312: changes to fix Checkstyle violation.
9eeaf0e
ATLAS-5312: changes to remove RenamePropagation.md and extend existin…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
addons/models/6000-Trino/patches/002-delete_propagation_typedef_patch.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "patches": [ | ||
| { | ||
| "id": "TYPEDEF_PATCH_6000_002_A", | ||
| "description": "Set propagateDelete=true on trino_table_hive_table endDef1 (hive_table → trino_table)", | ||
| "action": "SET_PROPAGATE_DELETE", | ||
| "typeName": "trino_table_hive_table", | ||
| "applyToVersion": "1.1", | ||
| "updateToVersion": "1.2", | ||
| "params": { | ||
| "endDefToken": "endDef1" | ||
| } | ||
| }, | ||
| { | ||
| "id": "TYPEDEF_PATCH_6000_002_B", | ||
| "description": "Set propagateDelete=true on trino_schema_hive_db endDef1 (hive_db → trino_schema)", | ||
| "action": "SET_PROPAGATE_DELETE", | ||
| "typeName": "trino_schema_hive_db", | ||
| "applyToVersion": "1.0", | ||
| "updateToVersion": "1.1", | ||
| "params": { | ||
| "endDefToken": "endDef1" | ||
| } | ||
| }, | ||
| { | ||
| "id": "TYPEDEF_PATCH_6000_002_C", | ||
| "description": "Set propagateDelete=true on trino_table_schema endDef2 (trino_schema → trino_table)", | ||
| "action": "SET_PROPAGATE_DELETE", | ||
| "typeName": "trino_table_schema", | ||
| "applyToVersion": "1.0", | ||
| "updateToVersion": "1.1", | ||
| "params": { | ||
| "endDefToken": "endDef2" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't there should be a patch for this, since atlas-2.5 is already released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are specific to the delete propagation. The earlier rename-related patch that was merged did not include these changes. This PR adds the required patch for the delete propagation functionality as well.