Skip to content

Correctly exclude prism when using external transforms #36049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 1 commit into from
Sep 9, 2025
Merged

Correctly exclude prism when using external transforms #36049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions sdks/python/apache_beam/runners/direct/direct_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ def accept(self, pipeline, is_interactive):
self.supported_by_prism_runner = False
else:
pipeline.visit(self)
# Avoid circular import
from apache_beam.pipeline import ExternalTransformFinder
if ExternalTransformFinder.contains_external_transforms(pipeline):
# TODO(https://github.com/apache/beam/issues/33623): Prism currently
# seems to not be able to consistently bring up external transforms.
# It does sometimes, but at volume suites start to fail. We will try
# to enable this in a future release.
self.supported_by_prism_runner = False
return self.supported_by_prism_runner

def visit_transform(self, applied_ptransform):
Expand All @@ -145,12 +153,6 @@ def visit_transform(self, applied_ptransform):
# being used.
if isinstance(transform, TestStream):
self.supported_by_prism_runner = False
if isinstance(transform, beam.ExternalTransform):
# TODO(https://github.com/apache/beam/issues/33623): Prism currently
# seems to not be able to consistently bring up external transforms.
# It does sometimes, but at volume suites start to fail. We will try
# to enable this in a future release.
self.supported_by_prism_runner = False
if isinstance(transform, beam.ParDo):
dofn = transform.dofn
# TODO(https://github.com/apache/beam/issues/33623): Prism currently
Expand Down
Loading