Skip to content

dummy pr - #38317

Closed
derrickaw wants to merge 1 commit into
masterfrom
tvalentyn-patch-1
Closed

dummy pr#38317
derrickaw wants to merge 1 commit into
masterfrom
tvalentyn-patch-1

Conversation

@derrickaw

Copy link
Copy Markdown
Collaborator

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for using pyproject.toml files as an alternative to setup.py when using the --setup_file pipeline option in Apache Beam. This change modernizes the packaging workflow for Python pipelines and includes necessary updates to the runner stager, pipeline options, and documentation. Additionally, the juliaset example has been refactored to demonstrate this new capability.

Highlights

  • Support for pyproject.toml: Added support for using pyproject.toml files with the --setup_file pipeline option, allowing for more modern Python packaging configurations.
  • Documentation Updates: Updated documentation to reflect the new support for pyproject.toml and clarified the usage of setup.py for legacy Beam versions.
  • Example Refactoring: Updated the juliaset example to use pyproject.toml for package definition and simplified the associated setup.py file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Beam SDK to support using pyproject.toml files with the --setup_file pipeline option, alongside various documentation and test suite adjustments. I have identified a potential issue regarding the addition of a generic setup.py file to the repository root, which may be redundant given the existing example-specific file. Additionally, I have suggested corrections for minor typos found in the pipeline options help text and the documentation.

Comment thread setup.py
Comment on lines +1 to +8
"""An optional setuptools configuration stub for the pipeline package.

Use pyproject.toml to define the package. Add this file if you must
use the --setup_file pipeline option on Beam 2.59.0 or earlier.
"""

import setuptools
setuptools.setup()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This file appears to have been added to the repository root by mistake. The juliaset example already contains its own setup.py in its specific directory (sdks/python/apache_beam/examples/complete/juliaset/setup.py). Adding a generic setup.py to the root of the repository is likely unintended and should be removed.

'During job submission a source distribution will be built and '
'the worker will install the resulting package before running any '
'custom code.'))
'Path to a file in that defines a Python package that needs to be '

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the help text: 'in that' should be 'that'.

Suggested change
'Path to a file in that defines a Python package that needs to be '
'Path to a file that defines a Python package that needs to be '

]

2. If your package requires if some programmatic configuration, or you need to use the `--setup_file` pipeline option, create a setup.py file for your project.
2. If your package requires if some programmatic configuration, or you need to use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a setup.py file for your project.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in this line: 'requires if some' should be 'requires some'.

Suggested change
2. If your package requires if some programmatic configuration, or you need to use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a setup.py file for your project.
2. If your package requires some programmatic configuration, or you need to use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a setup.py file for your project.

@derrickaw derrickaw closed this Apr 29, 2026
@derrickaw
derrickaw deleted the tvalentyn-patch-1 branch April 29, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants