dummy pr - #38317
Conversation
…mplify juliaset example.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for using pyproject.toml files as an alternative to setup.py when using the --setup_file pipeline option in Apache Beam. This change modernizes the packaging workflow for Python pipelines and includes necessary updates to the runner stager, pipeline options, and documentation. Additionally, the juliaset example has been refactored to demonstrate this new capability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Beam SDK to support using pyproject.toml files with the --setup_file pipeline option, alongside various documentation and test suite adjustments. I have identified a potential issue regarding the addition of a generic setup.py file to the repository root, which may be redundant given the existing example-specific file. Additionally, I have suggested corrections for minor typos found in the pipeline options help text and the documentation.
| """An optional setuptools configuration stub for the pipeline package. | ||
|
|
||
| Use pyproject.toml to define the package. Add this file if you must | ||
| use the --setup_file pipeline option on Beam 2.59.0 or earlier. | ||
| """ | ||
|
|
||
| import setuptools | ||
| setuptools.setup() |
There was a problem hiding this comment.
This file appears to have been added to the repository root by mistake. The juliaset example already contains its own setup.py in its specific directory (sdks/python/apache_beam/examples/complete/juliaset/setup.py). Adding a generic setup.py to the root of the repository is likely unintended and should be removed.
| 'During job submission a source distribution will be built and ' | ||
| 'the worker will install the resulting package before running any ' | ||
| 'custom code.')) | ||
| 'Path to a file in that defines a Python package that needs to be ' |
| ] | ||
|
|
||
| 2. If your package requires if some programmatic configuration, or you need to use the `--setup_file` pipeline option, create a setup.py file for your project. | ||
| 2. If your package requires if some programmatic configuration, or you need to use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a setup.py file for your project. |
There was a problem hiding this comment.
There is a typo in this line: 'requires if some' should be 'requires some'.
| 2. If your package requires if some programmatic configuration, or you need to use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a setup.py file for your project. | |
| 2. If your package requires some programmatic configuration, or you need to use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a setup.py file for your project. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.