Skip to content

Don't emit beam:coder:schema:v1 #38494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aIbrahiim wants to merge 1 commit into from
Closed

Don't emit beam:coder:schema:v1 #38494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_ULR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"comment": "Modify this file in a trivial way to cause this test suite to run",
"comment": "Modify this file in a trivial way to cause this test suite to run 2",
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
}
8 changes: 5 additions & 3 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/ModelCoderRegistrar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.apache.beam.sdk.coders.TimestampPrefixingWindowCoder;
import org.apache.beam.sdk.coders.VarLongCoder;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.options.StreamingOptions;
import org.apache.beam.sdk.schemas.SchemaCoder;
import org.apache.beam.sdk.transforms.windowing.GlobalWindow;
import org.apache.beam.sdk.transforms.windowing.IntervalWindow.IntervalWindowCoder;
Expand Down Expand Up @@ -140,8 +139,11 @@ public Map<Class<? extends Coder>, CoderTranslator<? extends Coder>> getCoderTra

@Override
public boolean isKnownCoder(Coder<?> coder, PipelineOptions options) {
if (coder.getClass() == SchemaCoder.class
&& StreamingOptions.updateCompatibilityVersionLessThan(options, "2.74")) {
if (coder.getClass() == SchemaCoder.class) {
// Don't emit beam:coder:schema:v1 yet: its payload carries Java-only
// blobs and no other SDK can decode it, so cross-SDK runners like the
// Python ULR break. Fall back to the legacy custom coder encoding
// until other SDKs add support (#33859).
return false;
}
return BEAM_MODEL_CODER_URNS.containsKey(coder.getClass());
Expand Down
Loading