Add drain states to PipelineResult#39020
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces explicit DRAINING and DRAINED states to the PipelineResult lifecycle. By adding these states, runners can now communicate the progress of a drain operation more accurately instead of overloading existing states like RUNNING or DONE. The changes span the core SDK, multiple runner implementations, and the job service, ensuring consistent state handling and preventing redundant cancellation attempts on jobs that have already finished draining. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the DRAINING and DRAINED pipeline states to the Beam SDK and integrates them across various runners, including Flink, Google Cloud Dataflow, and the Portability framework. It updates state mapping, job cancellation logic, and logging to support these new states, alongside adding corresponding unit tests to verify the behavior. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
R: @stankiewicz I've added the DRAINING and DRAINED states on the top of the drain support which was previous commit. Take a look. Thanks. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
This change adds DRAINING and DRAINED to PipelineResult.State so runners can report drain lifecycle states directly instead of mapping them to RUNNING, DONE, or UNKNOWN.
Tests are updated to cover the new state mappings and runner behavior.
addresses #38771