[Iceberg AddFiles] Add NameMapping when creating table

[ahmedabu98]

Small improvement to add NameMapping property directly when creating the table.

NameMapping is already added down the line in the CreateManifests step. This just does it in the same commit that creates the table, which helps merge two commits (create table + set namemapping) into one.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the process of creating Iceberg tables within the Beam SDK by embedding the NameMapping property directly into the table creation logic. This enhancement ensures that all new Iceberg tables are configured for name-based resolution from their inception, thereby simplifying the table setup and promoting more robust schema evolution. The change consolidates what would typically be two distinct operations (table creation and NameMapping configuration) into a single, atomic step.

Highlights

• Streamlined Iceberg Table Creation: The NameMapping property is now added directly during the initial creation of an Iceberg table, simplifying the setup process.
• Enforced Name-Based Resolution: This change ensures that newly created Iceberg tables default to name-based resolution, improving schema evolution robustness.
• Reduced Commits: By integrating NameMapping into the table creation, the need for a separate commit to set this property is eliminated.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Iceberg IO connector in Apache Beam to enforce name-based resolution by default when creating a table. It achieves this by adding a default name mapping to the table properties. The reviewer identified a critical issue where an UnsupportedOperationException could be thrown if the input tableProps is immutable, since MoreObjects.firstNonNull returns the original reference. A fix was suggested to copy the properties into a new mutable HashMap instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[ahmedabu98]

/gemini review

[gemini-code-assist]

Code Review

This pull request configures a default name mapping when creating a new Iceberg table in AddFiles.java to force name-based resolution instead of position-based resolution. The feedback suggests simplifying the properties map initialization using a ternary operator and replacing the null check with containsKey for better robustness and idiomatic Java.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[ahmedabu98]

assign set of reviewers

[github-actions]

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[tarun-google]

LGTM