fix AddFilesIT filter for BigLake - #39533
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Do we now which PR broke this test? It's failing since July 23, but recent IcebergIO changes #39408 do not match the timeline cc: @ahmedabu98 |
|
I think it's new behavior from the Lakehouse catalog. Let me confirm |
|
Just confirmed, they put things under an id directory for security reasons |
|
@Abacn Lakehouse now nests data under {table}/{id}/data/ (security). The IT assumed {table}/data/, so I updated the filter to match the table prefix and a /data/ segment so it works for both the old and new layouts and still ignores metadata under .../metadata/.... |
Fixes: #31931
Successful run: https://github.com/apache/beam/actions/runs/30426319856
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.