[Python] Deflake TextIO footer test - #39668
Open
bvolpato wants to merge 1 commit into
Open
Conversation
bvolpato
marked this pull request as ready for review
August 7, 2026 02:38
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39639.
TextSinkTest.test_write_pipeline_footerlet the runner choose its output shard count even though its assertions expect one trailing footer. Text sinks add the footer to every shard, so a multi-shard run leaves extra footer lines in the combined output.Use one output shard for this test, matching the adjacent header test. Per-shard header and footer behavior remains covered by
test_write_max_bytes_per_shard.Reproduction
Setting
num_shards=5on currentmasterreproduces the failure deterministically: four footer lines remain after the assertion removes the final footer.Testing
Fixes #39639.CHANGES.mdentry needed for a test-only change.