Fixes/coercion error logbook class filtering dynamic update#1430
Open
zan-mateusz wants to merge 3 commits into
Open
Fixes/coercion error logbook class filtering dynamic update#1430zan-mateusz wants to merge 3 commits into
zan-mateusz wants to merge 3 commits into
Conversation
zan-mateusz
force-pushed
the
fixes/coercion-error-logbook-class-filtering-dynamic-update
branch
from
01f7786 to
7bfc083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 fixes in separate commits:
When using a yaml list as input to an effector e.g.:
Currently it is parsed as a multiline string so you get
-and newline chars included. Commit 1 fixes this situation so we now get correctly:"[\"hello\",\"world\"]"Enhancement to allow filtering based on the prefix of logger name. It is accompanied by a minor UI tweak in a separate PR in brooklyn-ui. Current search capability does not allow searching for class names, just the message content, this enhancement allows it.