[CARBONDATA-4333][Doc] Update the declaration of supported String data types#4263
Merged
chenliang613 merged 1 commit intoapache:masterfrom Nov 11, 2023
Merged
[CARBONDATA-4333][Doc] Update the declaration of supported String data types#4263chenliang613 merged 1 commit intoapache:masterfrom
chenliang613 merged 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
…a types Why is this PR needed? CHAR and VARCHAR as String data types are no longer supported in Carbon. They should be deleted from doc's desc. What changes were proposed in this PR? CHAR and VARCHAR stop appearing as two String data types in doc. Does this PR introduce any user interface change? No Is any new testcase added? No
Contributor
|
LGTM |
| * String Types | ||
| * STRING | ||
| * CHAR | ||
| * VARCHAR |
Contributor
There was a problem hiding this comment.
Still, create table (a varchar(20), b char(20) stored as carbondata, are created as STRING type in carbondata with SPARK 3.1. CARBONDATA-4226 is not yet resolved. Can Refer org.apache.spark.sql.parser.CarbonSpark2SqlParser#getFields
Contributor
There was a problem hiding this comment.
As discussed in dev community , CARBONDATA-4226 be resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
CHAR and VARCHAR as String data types are no longer supported in Carbon. They should be deleted from doc's desc.
What changes were proposed in this PR?
CHAR and VARCHAR stop appearing as two String data types in doc.
Does this PR introduce any user interface change?
No
Is any new testcase added?
No