feat: Add Sample Locking + Massive Parallel test#15
Merged
hsluoyz merged 2 commits intoapache:masterfrom May 21, 2025
Merged
Conversation
|
now the data race which I was talking about is visible in the failing tests |
…ctually matter here
Contributor
Author
|
Man I really wish there was a way to label a race as "doesn't matter" because it really doesn't in this case, but fixed at any rate. |
|
thank you. |
Member
|
@pboyd04 what issue does this PR fix? Better with an issue |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added locking around the samples slice to avoid any race conditions. I could not cause the existing code to fail in anyway so I'm not really sure what the issue with the race condition was, but this should solve it.