Skip to content

feat: fix lint issues and go fmt files#21

Merged
hsluoyz merged 1 commit intoapache:masterfrom
pboyd04:LintAndGoFmt
Jun 28, 2025
Merged

feat: fix lint issues and go fmt files#21
hsluoyz merged 1 commit intoapache:masterfrom
pboyd04:LintAndGoFmt

Conversation

@pboyd04
Copy link
Copy Markdown
Contributor

@pboyd04 pboyd04 commented Jun 27, 2025

This fixes a number of staticcheck issues + runs "go fmt -s" on the files to get them in their simplest format. This basically just stops IDE's from complaining about the code.

@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Jun 28, 2025

@pboyd04 can you add the linter to CI first like: https://github.com/search?q=repo%3Acasdoor%2Fcasdoor%20linter&type=code ?

The linter errors should originate from this repo's CI, not from an IDE. Today your IDE reports these two linter issues, tomorrow his another IDE reports another three linter issues. The different IDEs bring different linter requirements.

@hsluoyz hsluoyz changed the title fix: Fix lint issues and go fmt files feat: fix lint issues and go fmt files Jun 28, 2025
@hsluoyz hsluoyz merged commit 4be17cb into apache:master Jun 28, 2025
7 checks passed
@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Jun 28, 2025

Linter CI issue created here: #22

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants