CASSANDRA-21128: CompactionManager.submitMaximal crash due to node restart race condition#4578
Open
teamconfx wants to merge 1 commit intoapache:trunkfrom
Open
CASSANDRA-21128: CompactionManager.submitMaximal crash due to node restart race condition#4578teamconfx wants to merge 1 commit intoapache:trunkfrom
teamconfx wants to merge 1 commit intoapache:trunkfrom
Conversation
33f7881 to
eef6cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix CASSANDRA-21128.
Issue
CompactionManager.submitMaximal() threw a NullPointerException when calling tasks.isEmpty() because getMaximalTasks() can return null during node restart scenarios (when there are uninterruptible compactions).
Fix Applied
File: src/java/org/apache/cassandra/db/compaction/CompactionManager.java:1179
Changed:
To:
Test Added
File: test/unit/org/apache/cassandra/db/compaction/CompactionManagerSubmitMaximalTest.java
Two test cases: