Improve writePlacementsAllSettled performance in large clusters with …#4592
Open
beobal wants to merge 1 commit intoapache:trunkfrom
Open
Improve writePlacementsAllSettled performance in large clusters with …#4592beobal wants to merge 1 commit intoapache:trunkfrom
beobal wants to merge 1 commit intoapache:trunkfrom
Conversation
…many ongoing range movements Only inflight MSOs which affect the local node need to be applied to determine the settled local ranges
krummas
requested changes
Feb 3, 2026
| if (localRangesAllSettled != null) | ||
| return localRangesAllSettled.getOrDefault(ksm.params.replication, EMPTY_LOCAL_RANGES); | ||
|
|
||
| ClusterMetadata metadata = this; |
Member
There was a problem hiding this comment.
don't think we need this?
or, if we do, we should probably only use metadata instead of this in the synchronized block below
| Iterator<MultiStepOperation<?>> iter = metadata.inProgressSequences.iterator(); | ||
| while (iter.hasNext()) | ||
| if (localRangesAllSettled != null) | ||
| return localRangesAllSettled.get(ksm.params.replication); |
Member
There was a problem hiding this comment.
this should also use getOrDefault (same as outside the synchronized block)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…many ongoing range movements
Only inflight MSOs which affect the local node need to be applied to determine the settled local ranges