Skip to content

ui: add cache for oslogo request using osId#11422

Merged
shwstppr merged 1 commit into
apache:4.22from
shwstppr:improve-oslogo-addcache
Jan 28, 2026
Merged

ui: add cache for oslogo request using osId#11422
shwstppr merged 1 commit into
apache:4.22from
shwstppr:improve-oslogo-addcache

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Aug 9, 2025

Description

When OsLogo component is used in the items of a list having same OS type it was causing listOsTypes API call multiple time. This change allows caching request and response value for 30 seconds. Caching behaviour is controlled using useCache flag.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:

oslogo-before.mp4

After:

oslogo-after.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

When OsLogo component is used in the items of a list having same OS type
it was causing listOsTypes API call multiple time. This change allows
caching request and response value for 30 seconds. Caching behaviour is
controlled using `useCache` flag.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.36%. Comparing base (7d59bfe) to head (8d0cc37).
⚠️ Report is 395 commits behind head on 4.22.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #11422   +/-   ##
=========================================
  Coverage     17.35%   17.36%           
- Complexity    15232    15234    +2     
=========================================
  Files          5885     5885           
  Lines        525618   525630   +12     
  Branches      64157    64163    +6     
=========================================
+ Hits          91225    91254   +29     
+ Misses       424094   424080   -14     
+ Partials      10299    10296    -3     
Flag Coverage Δ
uitests 3.63% <ø> (+<0.01%) ⬆️
unittests 18.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 9, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 9, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11422 (QA-JID-727)

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14585

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 9, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14588

@shwstppr
Copy link
Copy Markdown
Contributor Author

After:

oslogo-after.mp4

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11422 (QA-JID-750)

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, haven’t taken the time to test it yet (will have to add more similar templates to qa for this)

@shwstppr shwstppr changed the base branch from main to 4.22 November 13, 2025 12:33
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11422 (QA-JID-802)

@shwstppr shwstppr requested a review from vishesh92 November 28, 2025 05:54
@shwstppr shwstppr added this to the 4.22.1 milestone Jan 7, 2026
@sudo87 sudo87 self-assigned this Jan 27, 2026
Copy link
Copy Markdown
Contributor

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified

@shwstppr shwstppr merged commit 1b2ae13 into apache:4.22 Jan 28, 2026
25 checks passed
@shwstppr shwstppr deleted the improve-oslogo-addcache branch January 28, 2026 07:10
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
When OsLogo component is used in the items of a list having same OS type
it was causing listOsTypes API call multiple time. This change allows
caching request and response value for 30 seconds. Caching behaviour is
controlled using `useCache` flag.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 3, 2026
When OsLogo component is used in the items of a list having same OS type
it was causing listOsTypes API call multiple time. This change allows
caching request and response value for 30 seconds. Caching behaviour is
controlled using `useCache` flag.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants