CloudStack Volume support with ONTAP storage by rajiv-jain-netapp · Pull Request #13053 · apache/cloudstack

rajiv-jain-netapp · 2026-04-22T02:58:39Z

Description

Co-authored-by: Sandeep Locharla sandeep.locharla@netapp.com
Co-authored-by: Piyush Srivastava piyush5@netapp.com
Co-authored-by: Surya Gupta suryag@netapp.com

This PR...

Supports cloudstack-volume usecases support for NFS3 and iSCSI protocols.
Support for cloudStack-volume create/delete/attach/detach/snapshot-create.
Instance create/delete/snapshot-create support
Snapshot-create would not support
1. memory snapshot
2. user input for quicing option during snapshot creation

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Testing Done:

VM create

Validate the respective CloudStack volume

Storage view for the cloudStack volumes

VM snapshot support

Storage view, post snapshot create

CloudStack UI list view for snapshot

CloudStack volume snapshot support

Storage view, post snapshot create

CloudStack UI list view for snapshot

How did you try to break this feature and the system with this change?

… added EOF fixes

… added EOF fixes + correcting license header

Initial primary storage pool plugin skeleton

…POJOs" This reverts commit fe0f752.

…POJOs" This reverts commit 28faca1.

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28

* CSTACKEX-29 Cluster, SVM and Aggr Feign Client * CSTACKEX-29 Change the endpoint method name in feign client * CSTACKEX-29 Make the alignment proper * CSTACKEX-29 Added License Info * CSTACKEX-29 Resolve Review Comments * CSTACKEX-29 Remove Component Annotation from datastoredriverclass * CSTACKEX-29 Resolve Style check issues * CSTACKEX-29 Resolve ALL Style issues * CSTACKEX-29 Resolve Precommits Issues * CSTACKEX-29 Added Method comments and change the ontap response class name --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-31 NAS and Job Feign Client and POJOs * CSTACKEX-31 Fixed Checks Issues * CSTACKEX-31 Resolve Review Comments * CSTACKEX-31 Resolve Review Comments * CSTACKEX-31 Resolve Review Comments * CSTACKEX-31 Added Aggr and size to volume model * CSTACKEX-31 Change the export policy endpoint path * CSTACKEX-31 Fixed check styles --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-7: ONTAP Primary storage pool --------- Co-authored-by: Locharla, Sandeep <Sandeep.Locharla@netapp.com>

CSTACKEX-34: Upgrade to framework classes design

* CSTACKEX-35 Create Async * CSTACKEX-35 Added Null and empty check * CSTACKEX-35 Resolved review comments * CSTACKEX-35 Removed Type Casting for logger --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-1: Feign changes and fixes for getting storage pool creation to work * CSTACKEX-01: Create Primary Storage pool changes with working code * CSTACKEX-01: Addressed all review comments and updated some code * CSTACKEX-01: Made some changes to fix some errors seen during testing * CSTACKEX-01: Addressed additional comments --------- Co-authored-by: Locharla, Sandeep <Sandeep.Locharla@netapp.com>

piyush5netapp · 2026-05-08T13:09:32Z

@winterhazel I have pushed changes addressing most of the changes you suggested except for the comments "This if can be inverted to throw early and reduce the indentation" where we can discuss more. Please re-review.
Also, let me know if you want me to resolve conversation 1 by 1, I can do that .

winterhazel · 2026-05-08T13:15:38Z

@piyush5netapp thanks. I intend to have a look at the feedback and the new changes later today. I will resolve the open conversations that were already addressed as I read them.

winterhazel · 2026-05-14T01:30:04Z

@piyush5netapp @rajiv-jain-netapp I went through the reviews and resolved the ones that already seem addressed. Could you go through the comments that are still open and address them, or close with a comment if you judge it unnecessary (the indentation ones)?

- extracted the ONTAP plugin name to interface nane to use it from one place. - Corrected indentation gaps.

rajiv-jain-netapp · 2026-05-14T10:53:41Z

Thank you for your comments, @winterhazel.
I have updated the PR—please take a look at your convenience. I’ve addressed several of the pending items with additional commits today and have also provided responses to clarify some of the points raised.

rajiv-jain-netapp · 2026-05-18T07:36:40Z

@winterhazel @DaanHoogland @weizhouapache

Gentle reminder to review the PR. We are looking to incorporate feedback and progress further—your inputs would be highly valuable. Appreciate your support!

sureshanaparti · 2026-05-18T17:09:10Z

@blueorangutan package

blueorangutan · 2026-05-18T17:10:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-18T17:36:07Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17898

…intenance mode (#56)

- extracted the ONTAP plugin name to interface nane to use it from one place. - Corrected indentation gaps.

DaanHoogland · 2026-05-20T13:49:18Z

@blueorangutan package

blueorangutan · 2026-05-20T13:50:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-20T14:46:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17938

weizhouapache · 2026-05-21T06:39:31Z

@blueorangutan test

blueorangutan · 2026-05-21T06:40:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

winterhazel · 2026-05-22T01:15:03Z

Thank you for your comments, @winterhazel. I have updated the PR—please take a look at your convenience. I’ve addressed several of the pending items with additional commits today and have also provided responses to clarify some of the points raised.

@rajiv-jain-netapp there are still some comments that were not addressed. Could you have a look?

Also, I did not receive any responses on this day you commented, maybe you added them to a review and forgot to submit it?

winterhazel · 2026-05-22T01:19:10Z

+    @JsonProperty("name")
+
+    private String name;


Suggested change

@JsonProperty("name")

private String name;

@JsonProperty("name")

private String name;

Addressing some formatting issues from the latest commits

winterhazel · 2026-05-22T01:19:34Z

+    public void setName(String name) {
+        this.name = name;  }


Suggested change

public void setName(String name) {

this.name = name; }

public void setName(String name) {

this.name = name;

}

Formatting

winterhazel · 2026-05-22T01:20:24Z

        }
-        if (StringUtils.isBlank(providerName)) {
+
+        if (StringUtils.isBlank(providerName )) {


Suggested change

if (StringUtils.isBlank(providerName )) {

if (StringUtils.isBlank(providerName)) {

blueorangutan · 2026-05-22T06:31:03Z

[SF] Trillian test result (tid-16133)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 82743 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13053-t16133-kvm-ol8.zip
Smoke tests completed. 145 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_vm_backup_create_vm_from_backup	`Failure`	607.91	test_backup_recovery_nas.py
test_vm_backup_lifecycle	`Error`	0.09	test_backup_recovery_nas.py
test_router_dhcphosts	`Failure`	25.69	test_router_dhcphosts.py
ContextSuite context=TestSharedFSLifecycle>:setup	`Error`	0.00	test_sharedfs_lifecycle.py
test_10_attachAndDetach_iso	`Failure`	634.31	test_vm_life_cycle.py
test_01_create_vm_snapshots	`Failure`	606.75	test_vm_snapshots.py
test_02_revert_vm_snapshots	`Failure`	600.63	test_vm_snapshots.py
test_03_delete_vm_snapshots	`Failure`	0.03	test_vm_snapshots.py
test_01_create_volume	`Failure`	612.48	test_volumes.py
test_01_root_volume_encryption	`Failure`	709.50	test_volumes.py
test_02_data_volume_encryption	`Failure`	658.42	test_volumes.py
test_03_root_and_data_volume_encryption	`Failure`	665.48	test_volumes.py
test_02_attach_volume	`Failure`	1272.66	test_volumes.py
test_02_attach_volume	`Failure`	1272.68	test_volumes.py
test_03_download_attached_volume	`Failure`	664.79	test_volumes.py
test_04_delete_attached_volume	`Failure`	668.99	test_volumes.py
test_05_detach_volume	`Failure`	753.92	test_volumes.py
test_06_download_detached_volume	`Failure`	877.76	test_volumes.py
test_07_resize_fail	`Failure`	660.57	test_volumes.py
test_08_resize_volume	`Failure`	673.37	test_volumes.py
test_09_delete_detached_volume	`Failure`	670.10	test_volumes.py
test_10_list_volumes	`Failure`	660.47	test_volumes.py
test_11_attach_volume_with_unstarted_vm	`Failure`	769.75	test_volumes.py
test_12_resize_volume_with_only_size_parameter	`Failure`	667.00	test_volumes.py
test_13_migrate_volume_and_change_offering	`Failure`	803.51	test_volumes.py
test_14_delete_volume_delete_protection	`Failure`	664.25	test_volumes.py

matthiasdeblock · 2026-05-28T08:14:51Z

Hi

This is mainly about NFS and iSCSI, what about Fibre Channel SAN with MultiPath?

weizhouapache · 2026-05-28T08:30:37Z

Hi

This is mainly about NFS and iSCSI, what about Fibre Channel SAN with MultiPath?

good point

@rajiv-jain-netapp
is this also in your plan?

rajiv-jain-netapp · 2026-05-28T09:47:21Z

Hi
This is mainly about NFS and iSCSI, what about Fibre Channel SAN with MultiPath?

good point

@rajiv-jain-netapp is this also in your plan?

We planned to add support in incremental order for the protocols. Currently, we picked NFS3 and iSCSI and remaining protocols support would be added in subsequent releases.

Jain, Rajiv and others added 30 commits October 3, 2025 14:02

Initial primary storage pool plugin skeleton

4c8c8d9

Initial primary storage pool plugin skeleton - added license string

bf838b3

Initial primary storage pool plugin skeleton - added license string +…

b82fb40

… added EOF fixes

Initial primary storage pool plugin skeleton - added license string +…

1199d55

… added EOF fixes + correcting license header

Merge pull request #1 from NetApp/feature-CSTACKEX-24

ebc3f00

Initial primary storage pool plugin skeleton

Feignconfiguration and volume feignClient along with desired POJOs

28faca1

Feignconfiguration and volume feignClient along with desired POJOs

fe0f752

Revert "Feignconfiguration and volume feignClient along with desired …

35f1011

…POJOs" This reverts commit fe0f752.

Revert "Feignconfiguration and volume feignClient along with desired …

a03a2c4

…POJOs" This reverts commit 28faca1.

Feignconfiguration and volume feignClient along with desired POJOs

2e0efe8

Feignconfiguration and volume feignClient along with desired POJOs

a96eb9e

CSTACKEX-28: added copyright comment in the logger configuration

0f09c5f

CSTACKEX-28: added newline in the end of the file

2cc4b0c

CSTACKEX-28 - incorporated review comments

033c23d

Merge pull request #4 from NetApp/feature/CSTACKEX-28

2822946

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28

CSTACKEX-30 SAN Feign Client (#8)

a492797

* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

CSTACKEX-7: ONTAP Primary storage pool (#9)

25353c2

* CSTACKEX-7: ONTAP Primary storage pool --------- Co-authored-by: Locharla, Sandeep <Sandeep.Locharla@netapp.com>

CSTACKEX-34: Upgrade to framework classes design

973f5e2

CSTACKEX-34: incorporating the review comments

686a892

CSTACKEX-34: transient changes to the review comments

edfcdde

CSTACKEX-34: Unable to get checkstyle pass hence fixing this as well

73eb9f5

CSTACKEX-34: further review comments incorporations

465fffe

CSTACKEX-34: addressing checkstyle issues

3d6bd91

CSTACKEX-34: fix checksyle issues

5815ebd

Merge pull request #13 from NetApp/feature/CSTACKEX-34

618f957

CSTACKEX-34: Upgrade to framework classes design

CSTACKEX-35 Create Async (#14)

6c4b24e

* CSTACKEX-35 Create Async * CSTACKEX-35 Added Null and empty check * CSTACKEX-35 Resolved review comments * CSTACKEX-35 Removed Type Casting for logger --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

Merge branch 'apache:main' into main

54ddfa9

Srivastava, Piyush and others added 4 commits May 8, 2026 14:35

sync: fixed review comments without test class changes

199c463

sync: review comments changes for test files

11c937d

sync:fix full qualified import

a0234e4

bugfix/CSTACKEX-169: Fix enum case sensitive issues (#53)

cc9a6fb

winterhazel mentioned this pull request May 11, 2026

Review comments from community #13145

Closed

14 tasks

rajiv-jain-netapp added 3 commits May 14, 2026 14:55

- Removed occurences of string.format usage

0f3cb2b

- extracted the ONTAP plugin name to interface nane to use it from one place. - Corrected indentation gaps.

CSTACKEX-183: added missed import

03bf16f

CSTACKEX-183: Incorporated subsequent comments

37760c3

piyush5netapp and others added 3 commits May 19, 2026 18:25

Bugfix/cstackex 155: Fix VM provisioning after a pool comes out of ma…

732d6b4

…intenance mode (#56)

- Removed occurences of string.format usage

df5c26c

- extracted the ONTAP plugin name to interface nane to use it from one place. - Corrected indentation gaps.

fixes for merge conflicts

4d95d31

winterhazel reviewed May 22, 2026

View reviewed changes

	if (StringUtils.isBlank(providerName )) {
	if (StringUtils.isBlank(providerName)) {

Conversation

rajiv-jain-netapp commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

piyush5netapp commented May 8, 2026

Uh oh!

winterhazel commented May 8, 2026

Uh oh!

winterhazel commented May 14, 2026

Uh oh!

rajiv-jain-netapp commented May 14, 2026

Uh oh!

rajiv-jain-netapp commented May 18, 2026

Uh oh!

sureshanaparti commented May 18, 2026

Uh oh!

blueorangutan commented May 18, 2026

Uh oh!

blueorangutan commented May 18, 2026

Uh oh!

DaanHoogland commented May 20, 2026

Uh oh!

blueorangutan commented May 20, 2026

Uh oh!

blueorangutan commented May 20, 2026

Uh oh!

weizhouapache commented May 21, 2026

Uh oh!

blueorangutan commented May 21, 2026

Uh oh!

winterhazel commented May 22, 2026

Uh oh!

winterhazel May 22, 2026

Choose a reason for hiding this comment

Uh oh!

winterhazel May 22, 2026

Choose a reason for hiding this comment

Uh oh!

winterhazel May 22, 2026

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

matthiasdeblock commented May 28, 2026

Uh oh!

weizhouapache commented May 28, 2026

Uh oh!

rajiv-jain-netapp commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

rajiv-jain-netapp commented Apr 22, 2026 •

edited

Loading