UI: Fix VNF NIC mapping network select always disabled#13359
UI: Fix VNF NIC mapping network select always disabled#13359Gia-Bursulaia wants to merge 1 commit into
Conversation
Remove incorrect disabled attribute from VnfNicsSelection.vue. The attribute was a plain string instead of Vue binding, causing the select to always be disabled regardless of state.
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #13359 +/- ##
=============================================
- Coverage 18.10% 3.51% -14.60%
=============================================
Files 6037 464 -5573
Lines 542798 40159 -502639
Branches 66457 7560 -58897
=============================================
- Hits 98298 1413 -96885
+ Misses 433453 38556 -394897
+ Partials 11047 190 -10857
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Fixes VNF NIC mapping network select dropdown which was permanently disabled in the UI.
Root cause:
In
ui/src/views/compute/wizard/VnfNicsSelection.vuethedisabledattributewas written as a plain HTML string instead of a Vue reactive binding (missing
:prefix).In Vue/Ant Design, any non-empty string is treated as truthy, making the select
always disabled regardless of state.
Steps to reproduce:
Expected: Network dropdowns are enabled and selectable
Actual: All dropdowns permanently disabled, VNF cannot be deployed via UI
Tested on: CloudStack 4.22.1.0, KVM hypervisor
Types of changes
Feature/Enhancement Scale or Bug Severity