Skip to content

4.8.0.1 rc20160525 t1247#2363

Closed
toshen wants to merge 4 commits into
masterfrom
4.8.0.1-RC20160525T1247
Closed

4.8.0.1 rc20160525 t1247#2363
toshen wants to merge 4 commits into
masterfrom
4.8.0.1-RC20160525T1247

Conversation

@toshen
Copy link
Copy Markdown

@toshen toshen commented Dec 18, 2017

No description provided.

yadvr added 4 commits May 25, 2016 12:34
…admin

Restricts use of listemplates API with templatefilter=all for root admin only.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
- Restricts default login auth handler to ldap and native-cloudstack users
- Refactors and create re-usable method to find domain by id/path
- Adds unit test for refactored method in DomainManagerImpl
- Adds smoke test for login handler

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 18, 2017

@toshen was this created by mistake, I see my old commits which are already in master and 4.9/4.10 branches.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 19, 2017

I checked both the commits, they are in master and recent branches. For both the changes, subsequent fixes were fixed in #2009 and #1763. This PR does not describe the intention and why it's resubmitted @toshen ?

@rafaelweingartner
Copy link
Copy Markdown
Member

@rhtyd if there is no answer here, I vote for closing this PR.
That is one of the biggest benefits of using the Gitbox experiment.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 19, 2017

Thanks @rafaelweingartner I'll give another day to @toshen to reply, if there is no answer we can close this PR as potential spam/mistake.

@DaanHoogland
Copy link
Copy Markdown
Contributor

not a vaild pr

@rafaelweingartner rafaelweingartner deleted the 4.8.0.1-RC20160525T1247 branch April 3, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants