systemd: Fix -Dpid arg passing to systemd usage service

[yadvr]

This fixes regression introduced by refactoring PR #3163 where -Dpid
was incorrectly passed string $$ instead of parent PID integer.

Fixes #3203

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

[yadvr]

cc @andrijapanic @PaulAngus @ustcweizhou

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2627

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GabrielBrascher]

@rhtyd when debugging it I get the PID as a string "$JAVA_PID". With the silenced exception java.lang.NumberFormatException: For input string: "$JAVA_PID"

The solution on PR #3207 is not pretty, I agree with you. However, the systemd unit process the Environment as a string, not a script. Thus, had to execute a script with the ExecStartPost to provide a workaround on the PID.

[yadvr]

@GabrielBrascher @andrijapanic moved the JAVA_PID here so users can't change/mess it around. The systemd variable referencing is limiting, the fix was to use the ${VAR} syntax and not $VAR syntax. Can you believe it! https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines

[yadvr]

@GabrielBrascher fixed the issue, it was systemd variable referencing/syntax issue which per following docs should be ${VAR} instead of $VAR:
https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines

After my last commit, it's working again.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2628

[andrijapanicsb]

LGTM

Tested and the job does kick in as expected.

[GabrielBrascher]

@rhtyd @andrijapanic are you testing it with CentOS? On Ubuntu I still get error. Now the exception is: java.lang.NumberFormatException: For input string: "$$"

[andrijapanicsb]

yes, Centos7
let me build Ubuntu lab - 18.04 sounds fine ?

[GabrielBrascher]

@rhtyd @andrijapanic nevermind, my mistake when updating the script at this time. Due to the /bin/sh -ec '' it works now. Thanks!

[andrijapanicsb]

Cool - let's LGTM this one and close if you are OK with it @GabrielBrascher ?

[GabrielBrascher]

@rhtyd it looks good. Thanks!

Can you please also remove the lines that are silencing the exception? I don't see any reason for print on the stack trace (console) the exceptions.

cloudstack/usage/src/main/java/com/cloud/usage/UsageServer.java

Line 54 in 1d05fea

try {

} catch (Exception e) {
    e.printStackTrace();
}

[blueorangutan]

Trillian test result (tid-3418)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22699 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3210-t3418-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[yadvr]

@GabrielBrascher okay I'll move that to logging tomorrow.
@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3419)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3210-t3419-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[ustcweizhou]

tested ok in 4.11.2
LGTM

[GabrielBrascher]

All checks have passed (Travis, Jenkins, Trillian) passed and we have 3 LGTMs. I also tested and it worked. @rhtyd this PR is looking good.

@rhtyd just to keep track on the exception silenced; will you be able to add a commit addressing that exception silenced? Adding the JAVA_DEBUG is great, fixing that exception is also a great plus to help users on debugging.

Thanks for the work!

[yadvr]

@GabrielBrascher sorry forgot about that amidst dayjob work. I can do that tomorrow, or if you'd prefer you nay push your changes to this PR's branch.

[GabrielBrascher]

No problem @rhtyd, thanks!

[yadvr]

@GabrielBrascher done

[GabrielBrascher]

Thanks, @rhtyd! I am merging this PR.

[yadvr]

@GabrielBrascher, I've forward merged it to master now, in case you want to cut the RC or address another issue. Thanks.

[GabrielBrascher]

Time to spin out RC5 then, thanks!