Skip to content

fix duplicate tag exception as CloudRuntimeException#3348

Merged
yadvr merged 2 commits into
apache:4.11from
DaanHoogland:duplicateTagKey
May 30, 2019
Merged

fix duplicate tag exception as CloudRuntimeException#3348
yadvr merged 2 commits into
apache:4.11from
DaanHoogland:duplicateTagKey

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented May 23, 2019

Description

see #3339: a runtime exception is thrown but it should be converted to an error return. Wrapping it in a CloudRuntimeException should do the trick.

Fixes: #3339

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

by ui
Screenshot 2019-05-23 at 13 01 42

also a marvin test was added in component test test_tags.py

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@DaanHoogland DaanHoogland requested a review from PaulAngus May 23, 2019 08:49
@DaanHoogland DaanHoogland added this to the 4.11.3.0 milestone May 23, 2019
@DaanHoogland DaanHoogland changed the title [WIP] fix duplicate tag exception as CloudRuntimeException fix duplicate tag exception as CloudRuntimeException May 23, 2019
@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 24, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2783

@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 24, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3582)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32775 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3348-t3582-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 67 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 408.28 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 431.09 test_vpc_redundant.py

Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yadvr yadvr merged commit 910b08f into apache:4.11 May 30, 2019
@DaanHoogland DaanHoogland deleted the duplicateTagKey branch August 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants