Skip to content

Ui: Reset multiselect actions when refreshing listView in Instance page#3359

Merged
yadvr merged 1 commit into
apache:4.11from
smlshn:ui-reset-multiselect
May 30, 2019
Merged

Ui: Reset multiselect actions when refreshing listView in Instance page#3359
yadvr merged 1 commit into
apache:4.11from
smlshn:ui-reset-multiselect

Conversation

@smlshn
Copy link
Copy Markdown
Contributor

@smlshn smlshn commented May 26, 2019

Description

Enables the toolbar to reset to its initial state after any multiSelectAction completed.

Fixes: #3337

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots:

Screen Shot 2019-05-26 at 22 34 29

How Has This Been Tested?

Open Instances
Select any instance, on the toolbar Take VM Snapshot, Destroy Instance, Stop Instance buttons will be visible.
Follow operation path for any of these buttons.
Listview and toolbar will reset to its initial state.

Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested UI, actions restored to appropriate states. LGTM

@yadvr yadvr merged commit f1efcc1 into apache:4.11 May 30, 2019
@smlshn smlshn deleted the ui-reset-multiselect branch May 30, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants