Skip to content

vmware: fix potential NPE when memory hotplug capability is checked#3362

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:npe-fix-vmware-mem-check
May 31, 2019
Merged

vmware: fix potential NPE when memory hotplug capability is checked#3362
yadvr merged 1 commit into
apache:4.11from
shapeblue:npe-fix-vmware-mem-check

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented May 30, 2019

This fixes potential NPE case when memory hotpluggability is checked
based on the guest OS descriptor.

Fixes #3230 NPE case.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This fixes potential NPE case when memory hotpluggability is checked
based on the guest OS descriptor.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.3.0 milestone May 30, 2019
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented May 30, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2808

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented May 30, 2019

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@yadvr yadvr added the type:bug label May 30, 2019
@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3606)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37738 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3362-t3606-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 65 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_extract_template Failure 144.90 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_06_download_detached_volume Failure 172.69 test_volumes.py

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented May 30, 2019

Test lgtm, the failures were env related.

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rhtyd

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 8c387f9 into apache:4.11 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants