Skip to content

Fixed volume stats #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Spaceman1984 wants to merge 1 commit into from
Closed

Fixed volume stats #3798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3722,7 +3722,15 @@ protected GetVolumeStatsAnswer execute(GetVolumeStatsCommand cmd) {
VirtualMachineMO vmMo = dcMo.findVm(file.getDir());
Pair<VirtualDisk, String> vds = vmMo.getDiskDevice(file.getFileName(), true);
long virtualsize = vds.first().getCapacityInKB() * 1024;
long physicalsize = primaryStorageDatastoreMo.fileDiskSize(file.getPath());
long physicalsize = 0L;
VirtualMachineFileLayoutEx fileLayout = vmMo.getFileLayout();
List<VirtualMachineFileLayoutExFileInfo> files = fileLayout.getFile();
for(VirtualMachineFileLayoutExFileInfo fileInfo: files){
if (fileInfo.getName().contains("ROOT")){
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on second thought, there is no way here we know that we "only" want "ROOT" while iterating over a list of cmd.getVolumeUuids()

physicalsize += fileInfo.getSize();
}
}

if (statEntry.containsKey(chainInfo)) {
VolumeStatsEntry vse = statEntry.get(chainInfo);
if (vse != null) {
Expand Down