Skip to content

ui bug fix: cannot assign vms to internal lb in VPC#3832

Merged
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:ui-cannot-assign-vm-to-internal-lb
Jan 31, 2020
Merged

ui bug fix: cannot assign vms to internal lb in VPC#3832
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:ui-cannot-assign-vm-to-internal-lb

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

@ustcweizhou ustcweizhou commented Jan 24, 2020

Description

This fixes the issue that cannot assign VMs in Internal LB in VPC.
listView is overwritten due to commit 2e2b670 (#3161)

Fixes: #3827

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache mentioned this pull request Jan 24, 2020
Closed
DaanHoogland
DaanHoogland approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i see your fix, $listView gets written as a new var and addressed as the old var in line 172 👍

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jan 24, 2020

ok, i see your fix, $listView gets written as a new var and addressed as the old var in line 172 👍

@DaanHoogland yes exactly

@yadvr yadvr added this to the 4.13.1.0 milestone Jan 28, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 28, 2020

Needs someone to manually test the UI cc @andrijapanicsb @DaanHoogland @borisstoyanov

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 29, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2020

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2020

Packaging result: ✖centos6 ✖centos7 ✔debian. JID-696

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 29, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2020

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2020

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-706

@weizhouapache weizhouapache reopened this Jan 30, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 31, 2020

Tested against a 4.13.0.0 env, to assign VM to an internal LB:
Screenshot from 2020-01-31 15-22-23

@yadvr yadvr merged commit 75aa6e3 into apache:4.13 Jan 31, 2020
ustcweizhou added a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
@ustcweizhou
ui: fix cannot assign vms to internal lb in VPC (apache#3832)
3e9da2d 
This fixes the issue that cannot assign VMs in Internal LB in VPC.
listView is overwritten due to commit 2e2b670 (apache#3161)

Fixes: apache#3827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

@borisstoyanov borisstoyanov

@andrijapanicsb andrijapanicsb

Labels

component:UI type:bug

Projects

None yet

Milestone

4.13.1.0

Development

Successfully merging this pull request may close these issues.

8 participants

@ustcweizhou @weizhouapache @yadvr @DaanHoogland @blueorangutan @svenvogel @borisstoyanov @andrijapanicsb