Skip to content

LDAP truststore per domain#5816

Merged
yadvr merged 1 commit into
apache:4.16from
shapeblue:ldapsInDomains
Jan 3, 2022
Merged

LDAP truststore per domain#5816
yadvr merged 1 commit into
apache:4.16from
shapeblue:ldapsInDomains

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where the truststore is only queried on global level and not per domain.

Fixes: #5712

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@yadvr yadvr added this to the 4.16.1.0 milestone Dec 30, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 30, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2038

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-2755)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31797 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5816-t2755-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@yadvr yadvr merged commit e06a66b into apache:4.16 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants