server: fix update vm with unconstrained offering by shwstppr · Pull Request #5828 · apache/cloudstack

shwstppr · 2022-01-06T08:55:06Z

Description

Fixes #5694

Verify custom params for VM while updating using existing CPU speed when the VM offering is of unconstrained type.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

shwstppr · 2022-01-06T08:55:35Z

@blueorangutan package

blueorangutan · 2022-01-06T08:56:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-06T09:56:16Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2111

sureshanaparti · 2022-01-06T11:09:01Z

@blueorangutan test

blueorangutan · 2022-01-06T11:10:04Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache

code LGTM

blueorangutan · 2022-01-06T20:58:41Z

Trillian test result (tid-2807)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33700 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5828-t2807-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594

Verified behavior. LGTM.

shwstppr · 2022-01-07T08:16:32Z

@blueorangutan package

blueorangutan · 2022-01-07T08:17:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-07T09:06:01Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2127

sureshanaparti · 2022-01-07T09:41:39Z

@blueorangutan test

blueorangutan · 2022-01-07T09:42:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-01-07T20:18:41Z

Trillian test result (tid-2821)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36760 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5828-t2821-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Fixes apache#5694 Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

shwstppr · 2022-01-10T08:05:18Z

@blueorangutan package

blueorangutan · 2022-01-10T08:06:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-10T09:12:22Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2154

sureshanaparti · 2022-01-10T10:10:49Z

@blueorangutan package

blueorangutan · 2022-01-10T10:11:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-10T11:45:58Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2158

sureshanaparti · 2022-01-10T12:19:26Z

@blueorangutan test

blueorangutan · 2022-01-10T12:21:04Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-01-10T21:50:27Z

Trillian test result (tid-2841)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32667 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5828-t2841-kvm-centos7.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.63	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.11	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.20	test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	33.96	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	54.27	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	35.85	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	27.74	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	118.75	test_kubernetes_clusters.py
test_01_secure_vm_migration	`Error`	162.54	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	270.41	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	146.97	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	63.51	test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.53	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.54	test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	303.83	test_hostha_kvm.py

sureshanaparti · 2022-01-12T07:10:23Z

@blueorangutan package

blueorangutan · 2022-01-12T07:14:04Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-12T08:51:40Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2181

sureshanaparti · 2022-01-12T08:59:18Z

@blueorangutan test

blueorangutan · 2022-01-12T09:00:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-01-12T19:17:47Z

Trillian test result (tid-2866)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35566 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5828-t2866-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_disable_oobm_ha_state_ineligible	`Error`	1512.28	test_hostha_kvm.py

sureshanaparti · 2022-01-13T06:59:50Z

Trillian test result (tid-2866) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35566 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5828-t2866-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_disable_oobm_ha_state_ineligible Error 1512.28 test_hostha_kvm.py

failed test ^^^ not related to this PR changes.

shwstppr linked an issue Jan 6, 2022 that may be closed by this pull request

Can't change Setting on VM with Custom Unconstrained Compute Offering #5694

Closed

sureshanaparti reviewed Jan 6, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

sureshanaparti assigned shwstppr Jan 6, 2022

sureshanaparti approved these changes Jan 6, 2022

View reviewed changes

sureshanaparti requested review from GutoVeronezi, harikrishna-patnala and weizhouapache January 6, 2022 11:23

weizhouapache approved these changes Jan 6, 2022

View reviewed changes

sureshanaparti added this to the 4.16.1.0 milestone Jan 6, 2022

harikrishna-patnala reviewed Jan 7, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Pearl1594 approved these changes Jan 7, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

harikrishna-patnala approved these changes Jan 7, 2022

View reviewed changes

shwstppr commented Jan 7, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

sureshanaparti reviewed Jan 7, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

yadvr approved these changes Jan 8, 2022

View reviewed changes

yadvr reviewed Jan 8, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

server: fix update vm with unconstrained offering

e28fb2f

Fixes apache#5694 Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

shwstppr force-pushed the fix-update-vm-unconst-off branch from bfc3cf5 to e28fb2f Compare January 10, 2022 08:04

apache deleted a comment from blueorangutan Jan 12, 2022

sureshanaparti merged commit d78a815 into apache:4.16 Jan 13, 2022

sureshanaparti mentioned this pull request Jan 13, 2022

Can't change Setting on VM with Custom Unconstrained Compute Offering #5694

Closed

Conversation

shwstppr commented Jan 6, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

shwstppr commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

sureshanaparti commented Jan 6, 2022

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 6, 2022

Uh oh!

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shwstppr commented Jan 7, 2022

Uh oh!

blueorangutan commented Jan 7, 2022

Uh oh!

Uh oh!

blueorangutan commented Jan 7, 2022

Uh oh!

sureshanaparti commented Jan 7, 2022

Uh oh!

blueorangutan commented Jan 7, 2022

Uh oh!

blueorangutan commented Jan 7, 2022

Uh oh!

Uh oh!

shwstppr commented Jan 10, 2022

Uh oh!

blueorangutan commented Jan 10, 2022

Uh oh!

blueorangutan commented Jan 10, 2022

Uh oh!

sureshanaparti commented Jan 10, 2022

Uh oh!

blueorangutan commented Jan 10, 2022

Uh oh!

blueorangutan commented Jan 10, 2022

Uh oh!

sureshanaparti commented Jan 10, 2022

Uh oh!

blueorangutan commented Jan 10, 2022

Uh oh!

blueorangutan commented Jan 10, 2022

Uh oh!

sureshanaparti commented Jan 12, 2022

Uh oh!

blueorangutan commented Jan 12, 2022

Uh oh!

blueorangutan commented Jan 12, 2022

Uh oh!

sureshanaparti commented Jan 12, 2022

Uh oh!

blueorangutan commented Jan 12, 2022

Uh oh!

blueorangutan commented Jan 12, 2022

Uh oh!

sureshanaparti commented Jan 13, 2022

Uh oh!

Reviewers

Assignees