Skip to content

[Javadoc] Add usage examples to CharSet.contains(char)#1605

Merged
garydgregory merged 5 commits intoapache:masterfrom
Milanx22:javadoc-charset-contains
Feb 21, 2026
Merged

[Javadoc] Add usage examples to CharSet.contains(char)#1605
garydgregory merged 5 commits intoapache:masterfrom
Milanx22:javadoc-charset-contains

Conversation

@Milanx22
Copy link
Contributor

[Javadoc]: Add usage examples to CharSet.contains Javadoc, to make the doc more clear.

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class Javadoc contains such examples (pun); Javadoc examples here should either point to these or copy them.

@Milanx22
Copy link
Contributor Author

Thanks for the feedback @garydgregory , updated.

Updated example description to clarify usage of negation character.
@garydgregory garydgregory merged commit 2eca27e into apache:master Feb 21, 2026
@garydgregory garydgregory changed the title [Javadoc]: Add usage examples to CharSet.contains Javadoc [Javadoc]:Add usage examples to CharSet.contains Javadoc Feb 21, 2026
@garydgregory garydgregory changed the title [Javadoc]:Add usage examples to CharSet.contains Javadoc [Javadoc]:Add usage examples to CharSet.contains Feb 21, 2026
@garydgregory garydgregory changed the title [Javadoc]:Add usage examples to CharSet.contains [Javadoc] Add usage examples to CharSet.contains Feb 21, 2026
@garydgregory garydgregory changed the title [Javadoc] Add usage examples to CharSet.contains [Javadoc] Add usage examples to CharSet.contains(char) Feb 21, 2026
@garydgregory
Copy link
Member

@Milanx22
You missed a comment from the factory method to qualify the example, fixed and merged.
TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants