GH-1251: Upgrade Zookeeper to 3.9.3+ #1252
Merged
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
Mar 12, 2025
Member
There was a problem hiding this comment.
Seems these changes cause compile fail. Why do you make these changes?
Contributor
Author
There was a problem hiding this comment.
@tisonkun Thank-you for taking a look at the PR. It seems like in the newer version of zookeeper, the method that was being overridden has become final, so I just altered the access method to it.
Contributor
|
re-running CI |
kezhuw
approved these changes
Jun 17, 2025
Member
kezhuw
left a comment
kezhuw
left a comment
There was a problem hiding this comment.
TestReadOnly.testConnectionStateNewClient was flaky after ZOOKEEPER-4508, it should be fixed by ZOOKEEPER-4921 which supposed to be shipped in 3.9.4.
I am ok for it to be merged now. We could update to 3.9.4 once it merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.