Skip to content

Restructure data editor messaging with Message Registry#1647

Open
stricklandrbls wants to merge 1 commit intoapache:mainfrom
ctc-oss:data-editor-message-registry
Open

Restructure data editor messaging with Message Registry#1647
stricklandrbls wants to merge 1 commit intoapache:mainfrom
ctc-oss:data-editor-message-registry

Conversation

@stricklandrbls
Copy link
Copy Markdown
Contributor

@stricklandrbls stricklandrbls commented Mar 26, 2026

Closes #1058
Closes #669

Description

  • Implemented a Message Registry which provides type-safe message content inspection for messages sent between the data editor, dfdl extension, and the Svelte UI.
  • Restructured some legacy Svelte stores into Svelte v5 runes.
  • Resolved issues related to message content mismathcing and message content being processed by multiple data editors when the message was intended for a single data editor instance.

Wiki

  • I have determined that no documentation updates are needed for these changes
  • I have added the following documentation for these changes

Review Instructions including Screenshots

Developer Perspective Reviews

  1. In any portion of the data editor's extension source, verify that message content is appropriately inspected and the VSCode intellisense engine emits correct types when invoking this.panel.postMessage(...).
Screenshots ( dataEditorClient.ts -> 'fileInfo') image image
  1. In any portion of the data editor's Svelte UI source, verify that message content is appropriately inspected and the VSCode intellisense engine emits correct types when invoking addListener(...).
Screenshots ( DataEditorLineFeed.svelte -> 'viewportRefresh') image
  1. In any portion of the data editor's Svelte UI source, verify that message content is appropriately inspected and the VSCode intellisense engine emits correct types when invoking vscode.postMessage(...).
Screenshots ( App.svelte -> 'requestEditedData') image

Functionality Review

Verify that all message traffic behaves as expected. Message content can be identified within the ./src/ext_types/message.ts & ./src/ext_types/messageContent.ts

@stricklandrbls stricklandrbls added this to the 1.6.0 milestone Mar 26, 2026
@stricklandrbls stricklandrbls self-assigned this Mar 26, 2026
@stricklandrbls stricklandrbls added typescript code quality Issues related to code quality data editor Issues related to the Data Editor capability extension Issues releated to the VSCode Extension labels Mar 26, 2026
@stricklandrbls stricklandrbls force-pushed the data-editor-message-registry branch 3 times, most recently from 65b3fd8 to 8404e0c Compare March 26, 2026 18:11
@stricklandrbls stricklandrbls force-pushed the data-editor-message-registry branch from 8404e0c to dc8d15a Compare March 27, 2026 18:42
@stricklandrbls stricklandrbls force-pushed the data-editor-message-registry branch from dc8d15a to 55d963f Compare March 31, 2026 01:40
Copy link
Copy Markdown
Collaborator

@CoverRyan CoverRyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be failing consistently and it doesn't appear to be an issue with the CI.

@stricklandrbls
Copy link
Copy Markdown
Contributor Author

CI seems to be failing consistently and it doesn't appear to be an issue with the CI.

#1659 is the issue I created for fixing the CI

@shanedell
Copy link
Copy Markdown
Contributor

@stricklandrbls Will the updates to fix #1659 be added to this PR? My personal input would be, to add those changes here. I would rather have additional changes in this PR and a working CI then to merge this PR and introduce broken CI into main which requires another PR to fix.

@stricklandrbls
Copy link
Copy Markdown
Contributor Author

@stricklandrbls Will the updates to fix #1659 be added to this PR? My personal input would be, to add those changes here. I would rather have additional changes in this PR and a working CI then to merge this PR and introduce broken CI into main which requires another PR to fix.

Yeah those changes would fix the CI I created the separate issue because it required multiple additional dev dependencies.

I can add that issue as one that will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Issues related to code quality data editor Issues related to the Data Editor capability extension Issues releated to the VSCode Extension typescript

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Implement Cross Service Message Registry Implement MessageCommand Interfaces per Enumeration

3 participants