Restructure data editor messaging with Message Registry#1647
Restructure data editor messaging with Message Registry#1647stricklandrbls wants to merge 1 commit intoapache:mainfrom
Conversation
65b3fd8 to
8404e0c
Compare
8404e0c to
dc8d15a
Compare
dc8d15a to
55d963f
Compare
#1659 is the issue I created for fixing the CI |
|
@stricklandrbls Will the updates to fix #1659 be added to this PR? My personal input would be, to add those changes here. I would rather have additional changes in this PR and a working CI then to merge this PR and introduce broken CI into main which requires another PR to fix. |
Yeah those changes would fix the CI I created the separate issue because it required multiple additional dev dependencies. I can add that issue as one that will close this PR. |
Closes #1058
Closes #669
Description
Wiki
Review Instructions including Screenshots
Developer Perspective Reviews
this.panel.postMessage(...).Screenshots ( dataEditorClient.ts -> 'fileInfo')
addListener(...).Screenshots ( DataEditorLineFeed.svelte -> 'viewportRefresh')
vscode.postMessage(...).Screenshots ( App.svelte -> 'requestEditedData')
Functionality Review
Verify that all message traffic behaves as expected. Message content can be identified within the ./src/ext_types/message.ts & ./src/ext_types/messageContent.ts