Draft
Conversation
d665157 to
585e773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
v2.0.0-rc1@omega-edit/server/outlayoutstartServer(..., { logConfigFile })signatureWhy
Omega Edit
v2.0.0-rc1changes the client/server package layout and several APIs. This PR aligns the VS Code extension with the migration guide and the new helper APIs so we can validate the upgrade in CI.Impact
out/directory structureValidation
yarn installyarn compileyarn test:svelteyarn vite:pkgyarn packageNotes
node .\\out\\tests\\runTest.jsstill fails on this Windows environment because the downloadedCode.exerejects the@vscode/test-electronlaunch flags (--no-sandbox,--extensionTestsPath, etc.), so the VS Code integration suite could not be exercised locally here.