Skip to content

perf: Set ffi_safe flag conditionally for native_iceberg_compat scans [EXPERIMENTAL] #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andygrove wants to merge 1 commit into from
Closed

perf: Set ffi_safe flag conditionally for native_iceberg_compat scans [EXPERIMENTAL] #3409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions spark/src/main/scala/org/apache/spark/sql/comet/operators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,6 +1904,30 @@ case class CometSortMergeJoinExec(
}

object CometScanWrapper extends CometSink[SparkPlan] {
override def convert(
op: SparkPlan,
builder: Operator.Builder,
childOp: OperatorOuterClass.Operator*): Option[OperatorOuterClass.Operator] = {
val result = super.convert(op, builder, childOp: _*)
result.map { operator =>
op match {
case scan: CometScanExec if scan.scanImpl == CometConf.SCAN_NATIVE_ICEBERG_COMPAT =>
val hasPartitionColumns = scan.relation.partitionSchema.nonEmpty
val hasMissingColumns = scan.requiredSchema.fields.exists { field =>
!scan.relation.dataSchema.fieldNames.contains(field.name)
}
val ffiSafe = !hasPartitionColumns && !hasMissingColumns
if (ffiSafe) {
val scanProto = operator.getScan.toBuilder.setArrowFfiSafe(true).build()
operator.toBuilder.setScan(scanProto).build()
} else {
operator
}
case _ => operator
}
}
}

override def createExec(nativeOp: Operator, op: SparkPlan): CometNativeExec = {
CometScanWrapper(nativeOp, op)
}
Expand Down
Loading