feat: add support for GetTimestamp, parse_to_date, parse_to_timestamp expressions#3438
Open
rafafrdz wants to merge 11 commits intoapache:mainfrom
Open
feat: add support for GetTimestamp, parse_to_date, parse_to_timestamp expressions#3438rafafrdz wants to merge 11 commits intoapache:mainfrom
GetTimestamp, parse_to_date, parse_to_timestamp expressions#3438rafafrdz wants to merge 11 commits intoapache:mainfrom
Conversation
coderfender
reviewed
Feb 7, 2026
| chrono = { workspace = true } | ||
| datafusion = { workspace = true } | ||
| datafusion-common = { workspace = true } | ||
| chrono-tz = { workspace = true } |
Contributor
There was a problem hiding this comment.
@rafafrdz , this might not be intended change ?
coderfender
reviewed
Feb 7, 2026
| bytes = { version = "1.10.0" } | ||
| parquet = { version = "57.2.0", default-features = false, features = ["experimental"] } | ||
| datafusion = { version = "51.0.0", default-features = false, features = ["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] } | ||
| datafusion-common = { version = "51.0.0"} |
Contributor
|
@rafafrdz , Thank you for working on this and welcome to the datafusion community :) . I would suggest breaking down this PR by feature to make it easier for reviewers (and also the change log / release notes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetTimestampexpression, which allows the followings,ParseToDateexpression, and thereforeto_datefunction ( Closes [Feature] Support Spark expression: parse_to_date #3093 )ParseToTimestampexpression, and thereforeto_timestampfunction ( Closes [Feature] Support Spark expression: parse_to_timestamp #3109 )In order to add support both
to_dateandto_timestampspark sql functions, we need first to coverGetTimestampas an intermediate expression within the query plan when call eitherParseToDate(to_datefunction) orParseToTimestamp(to_timestampfunction).Note to maintainers
Since this is my first contribution to Apache DataFusion Comet, I may have missed some steps in the development or contribution process. Please let me know if anything is missing or needs adjustment.