test: improve array_distance sqllogictest coverage - #23971
Closed
2010YOUY01 wants to merge 1 commit into
Closed
Conversation
2010YOUY01
marked this pull request as draft
July 29, 2026 09:38
2010YOUY01
commented
Jul 29, 2026
| ---- | ||
| NULL NULL | ||
|
|
||
| # nested large-list inputs and nested nulls on either side |
Contributor
Author
There was a problem hiding this comment.
I'm unsure about this behavior, need some further investigation.
Contributor
Author
There was a problem hiding this comment.
It should be a bug, array_distance() should only support 1-D array, multi-dimensional array distance should not be supported.
I'll open a fix later.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23971 +/- ##
==========================================
+ Coverage 80.71% 80.75% +0.04%
==========================================
Files 1089 1096 +7
Lines 368293 373282 +4989
Branches 368293 373282 +4989
==========================================
+ Hits 297250 301439 +4189
- Misses 53332 53863 +531
- Partials 17711 17980 +269 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
continued in #23995 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Codecov reports low test coverage for this function, so this PR adds more SLT tests for it.
The tests were AI-generated, and I manually verified that the results are correct.
See
Codecovbot comment ->☔ View full report in Codecov by Harness->Indirect Changesfor the updated test coverage.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?